Skip to content

Fix bug in per tensor mul and add impls (#18481)#18481

Open
DrJessop wants to merge 1 commit intopytorch:mainfrom
DrJessop:export-D98045926
Open

Fix bug in per tensor mul and add impls (#18481)#18481
DrJessop wants to merge 1 commit intopytorch:mainfrom
DrJessop:export-D98045926

Conversation

@DrJessop
Copy link
Contributor

@DrJessop DrJessop commented Mar 24, 2026 •
edited by meta-codesync bot
Loading

Summary:

Before, to was reinterpreting the data to int. The real fix to prevent overflow is to just cast to float.

Differential Revision: D98045926

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 24, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18481

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job, 2 Unrelated Failures

As of commit 18c3905 with merge base b9a6b84 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 24, 2026
@meta-codesync
Copy link
Contributor

meta-codesync bot commented Mar 24, 2026

@DrJessop has exported this pull request. If you are a Meta employee, you can view the originating Diff in D98045926.

@github-actions
Copy link

github-actions bot commented Mar 24, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync meta-codesync bot changed the title Fix bug in per tensor mul and add impls Fix bug in per tensor mul and add impls (#18481) Mar 25, 2026
DrJessop pushed a commit to DrJessop/executorch that referenced this pull request Mar 25, 2026
@facebook-github-bot
Fix bug in per tensor mul and add impls (pytorch#18481)
1fd0270 
Summary:

Before, to was reinterpreting the data to int. The real fix to prevent overflow is to just cast to float.

Differential Revision: D98045926
@meta-codesync
Fix bug in per tensor mul and add impls (pytorch#18481)
18c3905 
Summary:
Pull Request resolved: pytorch#18481

Before, to was reinterpreting the data to int. The real fix to prevent overflow is to just cast to float.

Differential Revision: D98045926
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@DrJessop